Open smallsaucepan opened 4 hours ago
Hi! Thanks for the suggestion and for supporting the package!
If possible, could you split it into two PRs—one to fix the type export issue and another to add CJS support? This would make the review process easier.
Sure thing 👍 Will do the smaller type export one first.
Oh, actually just saw #8, which had a similar goal to this issue. That PR was merged in e079fa8 but then rolled back some months later by 7bfaa6c.
Did something go wrong? Couldn't find any chatter about the reason.
The PR was merged but rolled back before publishing a new version on npm. It references a PR in another repository that hasn’t been merged. I still have doubts about the ideal solution and want to be cautious with breaking changes.
Hi @luizbarboza. We're quite keen to use polyclip-ts over in Turfjs. However having some issues gettings the types imported e.g.
One fix would be to flesh out the exports section of polyclip-ts/package.json, so would be happy to prepare a PR for that. However, without packaging CJS version of the library as well, the best we could hope for from arethetypeswrong would be:
Would you like a PR that will generate and export CJS also? Or do you prefer to stick with ESM only?
Thanks for maintaining the package!