search

luizgrp / SectionedRecyclerViewAdapter

An Adapter that allows a RecyclerView to be split into Sections with headers and/or footers. Each Section can have its state controlled individually.
MIT License
1.68k stars 372 forks source link

Bug fixed. #54

Closed yccheok closed 7 years ago

yccheok commented 7 years ago

Sorry for the missing thingy

luizgrp commented 7 years ago

no worries, next week I will update the demo app to include the empty state and will see if we can write an unit test to cover the constructor with SectionParameters

yccheok commented 7 years ago

2017-07-01 03_06_25-store

@luizgrp

Not sure why. After updating the gradle.build to 1.1.1, I'm still getting the old code (The old code which doesn't initialize empty resource id) although I had tried to restart the IDE and rebuild multiple times.

Any idea?

yccheok commented 7 years ago

@luizgrp

I think something went wrong during the merge process?

Because if I look at the master branch

https://github.com/luizgrp/SectionedRecyclerViewAdapter/blob/master/library/src/main/java/io/github/luizgrp/sectionedrecyclerviewadapter/Section.java#L95

The fix isn't there. Seem weird ?!

luizgrp commented 7 years ago

@yccheok very weird, I must have messed up with the develop branch thanks for spotting that, hope everything is fine in v1.1.2 :crossed_fingers:

yccheok commented 7 years ago

@luizgrp

Thank you very much. Works good now. +1