search

luizgrp / SectionedRecyclerViewAdapter

An Adapter that allows a RecyclerView to be split into Sections with headers and/or footers. Each Section can have its state controlled individually.
MIT License
1.68k stars 372 forks source link

Enhance notify3 #66

Closed yccheok closed 7 years ago

yccheok commented 7 years ago

notifyNotLoadedStateChanged notifyStateChangedToLoaded notifyStateChangedFromLoaded

yccheok commented 7 years ago

Reviewed.

Please note that, I also did a minor optimization along the way.

https://github.com/luizgrp/SectionedRecyclerViewAdapter/pull/66/files#diff-5cdcd5419131d0531d7730fbec3fff97R430

yccheok commented 7 years ago

Changed according to review.

luizgrp commented 7 years ago

awesome, thanks 💥

yccheok commented 7 years ago

@luizgrp

I think there's possible bug in

notifyStateChangedToLoaded
notifyStateChangedFromLoaded

As, when state is LOADED, the content item count is possible to have 0. We didn't handle such case, isn't it?