luizirber / niffler

Simple and transparent support for compressed files.
Apache License 2.0
75 stars 7 forks source link

move definitions and rename some types #11

Closed luizirber closed 4 years ago

luizirber commented 4 years ago

(I'm leaving this as a draft PR because I'm not sure this should be merged, just trying out some ideas)

Main changes

codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (choose_compression_level@a3eda38). Click here to learn what that means. The diff coverage is 68.38%.

Impacted file tree graph

@@                     Coverage Diff                     @@
##             choose_compression_level      #11   +/-   ##
===========================================================
  Coverage                            ?   75.64%           
===========================================================
  Files                               ?        2           
  Lines                               ?      234           
  Branches                            ?       35           
===========================================================
  Hits                                ?      177           
  Misses                              ?       24           
  Partials                            ?       33
Impacted Files Coverage Δ
src/compression.rs 67.44% <67.44%> (ø)
src/lib.rs 85.71% <73.07%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a3eda38...d45994d. Read the comment docs.

natir commented 4 years ago

Thanks @luizirber I think all this change are good we can merge it !