Closed luizirber closed 4 years ago
:exclamation: No coverage uploaded for pull request base (
choose_compression_level@a3eda38
). Click here to learn what that means. The diff coverage is68.38%
.
@@ Coverage Diff @@
## choose_compression_level #11 +/- ##
===========================================================
Coverage ? 75.64%
===========================================================
Files ? 2
Lines ? 234
Branches ? 35
===========================================================
Hits ? 177
Misses ? 24
Partials ? 33
Impacted Files | Coverage Δ | |
---|---|---|
src/compression.rs | 67.44% <67.44%> (ø) |
|
src/lib.rs | 85.71% <73.07%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a3eda38...d45994d. Read the comment docs.
Thanks @luizirber I think all this change are good we can merge it !
(I'm leaving this as a draft PR because I'm not sure this should be merged, just trying out some ideas)
Main changes
CompressionFormat
andCompressionLevel
lost theCompression
part, and moved intosrc/compression.rs
. Main consequence on the public API is that you can useor
NifflerError
toError
, this way we can doinstead of having to write
NifflerError
. And crates usingniffler
can doniffler::Error
instead ofniffler::NiflerError
.read_compression
,new_lzma_{encoder,decoder}
andnew_bz2_{encoder,decoder} to
src/compression.rs, and made them
pub(crate)(so we can call them in
src/lib.rs`).