search

luizirber / niffler

Simple and transparent support for compressed files.
Apache License 2.0
75 stars 7 forks source link

Replace GzDecoder with MultiGzDecoder #28

Closed luizirber closed 4 years ago

luizirber commented 4 years ago

Fixes #27

From checking the flate2 code the only difference between GzDecoder and MultiGzDecoder is a .multi(true) flag for GzDecoder that keeps decoding data after the first member is finished, so it should be safe to replace it (and it doesn't break any niffler dependants, since it is exposed as a Box<dyn io::Read> anyway).

codecov[bot] commented 4 years ago

Codecov Report

Merging #28 into master will decrease coverage by 2.70%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
- Coverage   98.64%   95.94%   -2.71%     
==========================================
  Files           2        2              
  Lines         148      148              
==========================================
- Hits          146      142       -4     
- Misses          2        6       +4
Impacted Files Coverage Δ
src/lib.rs 93.97% <100.00%> (-4.82%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5ae50a2...ff68046. Read the comment docs.