search

luizirber / niffler

Simple and transparent support for compressed files.
Apache License 2.0
75 stars 7 forks source link

niffler dependent on failure #45

Closed Ebedthan closed 3 years ago

Ebedthan commented 3 years ago

Hi,

After RUSTEC pointed out that failure is deprecated, I've found doing crate tree inside my project that niffler is dependent on the failure crate. Is there a way to get rid of failure?

Thanks in advance.

luizirber commented 3 years ago

Hi @Ebedthan! failure is an indirect dependency (bgzip uses it). If you want to avoid it, you can select what formats you want to support explicitly using features, as pointed in the README:

niffler = { version = "2.3.1", default-features = false, features = ["bz2", "lzma", "gz"] }
Ebedthan commented 3 years ago

Thanks for pointing this out. Closing this issue and contacting bgzip maintainer.

Ebedthan commented 3 years ago

Hi @luizirber , Following my PR on bgzip repo, we have updated bgzip to turn from failure to thiserror and released v0.2.0 on crate.io. So you need to update your cargo.toml to get rid of failure. Thank you everyone.

luizirber commented 3 years ago

Thanks! 2.3.2 released, enjoy =]