search

luizirber / niffler

Simple and transparent support for compressed files.
Apache License 2.0
75 stars 7 forks source link

Replace xz2 with liblzma #64

Closed luizirber closed 5 months ago

luizirber commented 5 months ago

xz2 is outdated [^1], liblzma is an updated fork.

[^1]: that might not be bad, since being outdated meant the updated to the hacked version was never done :sweat_smile: https://github.com/alexcrichton/xz2-rs/issues/124#issuecomment-2027962381

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.57%. Comparing base (ff7dae4) to head (5899a91).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #64 +/- ## ========================================== + Coverage 81.08% 81.57% +0.49% ========================================== Files 12 12 Lines 259 266 +7 ========================================== + Hits 210 217 +7 Misses 49 49 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

natir commented 5 months ago

Nice I fix trouble with xz, lzma features.

natir commented 5 months ago

I would wait finish test before merge.

Maybe after, this merge we could perform a dependency update before a new minor release ?

luizirber commented 5 months ago

I would wait finish test before merge.

Maybe after, this merge we could perform a dependency update before a new minor release ?

yup! Thanks for the quick review =]