search

luizirber / nthash

ntHash implementation in Rust
Other
34 stars 6 forks source link

Needless fn #8

Closed thomasmulvaney closed 5 years ago

thomasmulvaney commented 5 years ago

Hi @luizirber, thanks for making me aware of const fn. Having looked through docs a bit, it seems that you can probably just go about constructing the const arrays without the help of any extra const fn.

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@81f0c37). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #8   +/-   ##
=========================================
  Coverage          ?   62.89%           
=========================================
  Files             ?        3           
  Lines             ?      159           
  Branches          ?        0           
=========================================
  Hits              ?      100           
  Misses            ?       59           
  Partials          ?        0
Impacted Files Coverage Δ
src/lib.rs 56.31% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 81f0c37...3fb07aa. Read the comment docs.

luizirber commented 5 years ago

Indeed, thanks @thomasmulvaney !