luizirber / nthash

ntHash implementation in Rust
Other
34 stars 7 forks source link

Support lowercase bases? #9

Open luizirber opened 3 years ago

luizirber commented 3 years ago

This error in rust-mdbg is triggered because lowercase bases are passed to nthash. Possible solutions: 1) users of the crate need to provide uppercase (non-repeat masked) nucleotides. This will probably trigger another allocation, so potentially slower. 2) accept lowercase bases in nthash. One solution is modifying H_LOOKUP and RC_LOOKUP to also have the lowercase variants.

RagnarGrootKoerkamp commented 2 months ago

Similarly, it may be nice to accept [0,1,2,3] values for convenience as well, for when data is already packed.