search

luizirber / sourmash_cpp

0 stars 0 forks source link

Sourmash submodule update #5

Open mr-eyes opened 3 years ago

mr-eyes commented 3 years ago

Do we need here to update the Sourmash submodule to sync with sourmash:latest? Or this is just to check we can import Sourmash from the C++ generated header?

luizirber commented 3 years ago

Good questions. I think it is probably a good idea to move the code here into an example/ directory in the sourmash repo, and move the C++ header to include/ (side-by-side with the C header). This also allows running the cmake example in CI and verify it is not diverging over time (which I think is happening here at the moment :grimacing: )

mr-eyes commented 3 years ago

Great! I'll be happy contributing into this :)