luizm / action-sh-checker

A GitHub action that performs static analysis for shell scripts using shellcheck, shfmt and checkbashisms.
MIT License
132 stars 12 forks source link

Ignore checkbashisms false positives #38

Closed rasa closed 3 years ago

rasa commented 3 years ago

This fixes checkbashisms returning error 4 when reporting could not find any possible bashisms in bash script. See https://github.com/duggan/shlint/blob/0fcd979319e3f37c2cd53ccea0b51e16fda710a1/lib/checkbashisms#L489

Here's a successful run using this PR:

Validating 'bashisms' for shell scripts files using checkbashisms

could not find any possible bashisms in bash script ...

The files above have some checkbashisms issues

Ignoring 'could not find any possible bashisms in bash script' issues
luizm commented 3 years ago

I'm sorry @rasa I've started to include the parameter ONLY_DIFF, but I can't complete it now.

I just remove the code :)

luizm commented 3 years ago

@rasa could you get a try this one: https://github.com/luizm/action-sh-checker/releases/tag/v0.1.12