luizoti / script.library.integration.tool

Kodi addon that allows video plugin content to be integrated into your library
GNU General Public License v2.0
13 stars 5 forks source link

BBC iPlayer WWW support + a question #18

Closed t0mtee closed 2 years ago

t0mtee commented 3 years ago

Describe the bug It would be good to add iPlayer WWW support

To Reproduce This is what currently happens with iPlayer WWW:

  1. Go to 'iPlayer WWW' addon
  2. Search for a show
  3. Click on 'Add selected item to library'
  4. See error 'Show could not be identified'

Expected behavior Show gets added to the library

Desktop (please complete the following information):

Additional context This is the right download for the addon, right? I'm not sure if I have the original addon or the forked installed.

Kodi log Provide the kodi log with error: kodi.log

luizoti commented 3 years ago

Hey,

  1. Is this a free addon? (need a signature?)
  2. Is this a pirated addon (an addon that makes the content illegally available)?

If I'm paid, I can't add support without having a subscription.

If it's a pirated addon I won't add support, LIT follows kodi forum guidelines that don't accept piracy: https://forum.kodi.tv/showthread.php?tid=327514&pid=3043341#pid3043341

t0mtee commented 3 years ago

Its a free addon, available on the official repo

luizoti commented 3 years ago

Good, i Will try to add support in future

t0mtee commented 3 years ago

Good, i Will try to add support in future

could I get an eta?

luizoti commented 3 years ago

Problaby in this week.

t0mtee commented 3 years ago

Problaby in this week.

nice, thanks for taking in my suggestion (also thanks for continuing the LIT project, it was a shame to see the dev stop working on it and had to move to Add to Lib, an addon which is several years old and VERY slow)

t0mtee commented 3 years ago

Just some more info, I have migrated my entire Kodi build to Matrix, iPlayer is still not supported

luizoti commented 3 years ago

This complicates things, I don't intend to release update for kodi 18 anymore, when IPlayer works in Matrix I try to add support.

t0mtee commented 3 years ago

This complicates things, I don't intend to release update for kodi 18 anymore, when IPlayer works in Matrix I try to add support.

This is the reason I migrated to Matrix, slowly I will miss out on addon updates. Also, iPlayer is working in Matrix, I just tried it.

t0mtee commented 3 years ago

Oh, I see where the confusion came from now. When I said "iPlayer is still not supported", I meant the LIT didn't work with iPlayer on Matrix. iPlayer itself works fine, LIT doesn't support it.

luizoti commented 3 years ago

haaa, ok, if matrix support, i will check.

t0mtee commented 3 years ago

lemme know when it's ready and thanks!

t0mtee commented 3 years ago

@luizoti hey, how's the support going?

luizoti commented 3 years ago

I'm currently trying to optimize a core function of LIT and it's a bit complex, I couldn't work on iplayer. What content did you try to add from iplayer?

t0mtee commented 3 years ago

I'm currently trying to optimize a core function of LIT and it's a bit complex, I couldn't work on iplayer. What content did you try to add from iplayer?

Sorry for late response I was trying to add Doctor Who

luizoti commented 3 years ago

Hi, sorry @OsoaGitHub for the delay, I finally managed to do the tests with the BBC, and I found some problems:

Problem 1

In the test I did, for example, when opening the dr. who for example instead of showing a list with the folders of the seasons, it shows the episodes of the first season and the folders of the other seasons.

And what's wrong?

I'm going to have to juggle a way to deal with this nonsensical structure, it's probably going to be a bunch of hard code to deal with.

If you really need to watch for this addon, ask the devs to change this behavior.

BBC, example of bad directories: https://imgur.com/NF6G1t9.png HBO MAX good example: https://imgur.com/RSzqzpM.png

Problem 2

The way lit works, it needs addons to return some types of data to be processed, I rewrote it to deal as best as possible with the differences, but the idea is that all addons return the same data. follows a bad example from the BBC:

    {
        "art": {
            "icon": "image://DefaultFolder.png/",
            "thumb": "image://https%3a%2f%2fichef.bbci.co.uk%2fimages%2fic%2f832x468%2fp01hz772.jpg/"
        },
        "episode": -1,
        "fanart": "",
        "file": "plugin://plugin.video.iplayerwww/?url=https%3A%2F%2Fwww.bbc.co.uk%2Fiplayer%2Fepisodes%2Fp00db1jf%2Fzoo-quest&mode=128&name=%5BB%5DZoo+Quest%5B%2FB%5D&iconimage=https%3A%2F%2Fichef.bbci.co.uk%2Fimages%2Fic%2F832x468%2Fp01hz772.jpg&description=David+Attenborough+searches+for+one+of+the+rarest+animals+of+Madagascar%2C+the+indri.+%281961%29&subtitles_url=&logged_in=False",
        "filetype": "directory",
        "label": "[B]Zoo Quest[/B]",
        "season": -1,
        "showtitle": "",
        "title": "[B]Zoo Quest[/B]",
        "type": "unknown",
        "year": 0
    }

Some data can be added by the devs, when creating the lists with the folders in the addon.

For now it's not possible to add support, unfortunately, if the addon is updated and becomes more standardized, I can review it.

luizoti commented 2 years ago

Closing this issue.