search

luizperes / simdjson_nodejs

Node.js bindings for the simdjson project: "Parsing gigabytes of JSON per second"
https://arxiv.org/abs/1902.08318
Apache License 2.0
549 stars 25 forks source link

Update mocha to a version > 7.1.1 #32

Closed luizperes closed 4 years ago

luizperes commented 4 years ago

Problem Mocha 7.1.0 is using an outdated version of mkdirp and that is causing a warning of low severity vulnerability. Updating mocha to 7.1.1 (the latest at the moment on npm) is no good as well, as it is using mkdirp@0.5.3 and we get a deprecated message: Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises in 1.x.).

Solution We will have to wait for mocha to update its version so to fix that deprecated warning.

Screen Shot 2020-04-08 at 1 57 39 AM

CC @nojvek

nojvek commented 4 years ago

Iwe only use mocha in dev env (I.e building the module). After its published, mocha shouldn’t be needed so this should be okay.

But you’re right. Mocha should update themselves to be warning free.

luizperes commented 4 years ago

Fixed on #39