search

luk27official / ivysilani-mpd-extractor

Extract .mpd files from iVysilani
MIT License
1 stars 1 forks source link

"Přehrát" button not found on time-limited resources #3

Closed pavelruzicka closed 4 hours ago

pavelruzicka commented 6 hours ago

Hi,

as the issue name suggests, the Přehrát button which the extractor relies on can not be found on URLs linking to resources which are time limited. For example, https://www.ceskatelevize.cz/porady/14757154647-karel-kryl-v-dansku/ expires on December 1st which makes the play button display a custom text ("Přehrát (dostupné do 1. 12. 21:30)"). I suggest only checking whether the button innerHTML starts with "Přehrát"?

I have obviously found my way around this issue so please do not feel urged to fix it asap, just letting you know.

EDIT: Sorry, I thought the XPath selector was checking for innerHTML but it relies on the ARIA label. That seems to be missing altogether on the time-expiring play button.

luk27official commented 4 hours ago

Hi, thanks for the report. Changed: https://github.com/luk27official/ivysilani-mpd-extractor/blob/a345ac3b552136e9dc1bee5d7b40c7ec8fa80e5c/extract.py#L19-L20 Let me know if you encounter any unexpected behavior.

pavelruzicka commented 2 hours ago

Thanks for the lightning response.

The SERIES_RUN_XPATH selector seems to be unable to find the play button. I encounter this issue on https://www.ceskatelevize.cz/porady/1093417350-manez-bolka-polivky/, for example.

The traceback ends with selenium.common.exceptions.NoSuchElementException: Message: no such element: Unable to locate element: {"method":"xpath","selector":"//*[starts-with(normalize-space(text()), "Přehrát")]".