luk400 / vim-jukit

Jupyter-Notebook inspired Neovim/Vim Plugin
MIT License
582 stars 23 forks source link

Inline figures not showing in iterm2 + tmux #15

Open AreUGroot opened 2 years ago

AreUGroot commented 2 years ago

Hi! I encountered another issue. Inline figures failed to show in the ipython panel in tmux.

I have added let g:jukit_terminal='tmux' and let g:jukit_inline_plotting=1 in .vimrc and ipython returns module://imgcat as expected.

Figure2

.

Thank you for your time!

luk400 commented 2 years ago

See this issue

eerii commented 1 year ago

Hey, sorry for reopening this issue, but I am encountering problems even after installing the specific tmux 3.2a version.

problem

The matplotlib plot is not showing inline (tested with and without plt.plot()). The only config I have is specifying vim.g.jukit_terminal = 'tmux'. I am using neovim and iTerm2. If I don't specify the terminal then it shows the image in a separate python window and works as expected, but it doesn't show inline.

Thank you so much for your plugin, it is wonderful despite this tiny issue!

luk400 commented 1 year ago

Hi, sorry for the late reply. Unfortunately I can not reproduce this issue. Did you install tmux via wget https://raw.githubusercontent.com/Homebrew/homebrewcore/e44425df5a8b3c8c24073486fa7e355f3ac19657/Formula/tmux.rb && brew install ./tmux.rb? For me the plot is displayed in the terminal without problems, and the message tmux: option requires an argument -- t that you're seeing suggests to me that we're not using exactly the same tmux version.

For reference, I tested using: MacOS Big Sur Version 11.6.7 iTerm2 Build 3.4.15 tmux installed via the above command neovim version v0.8.3

nikisix commented 11 months ago

I had this error too. Make sure that you python -m pip install imgcat for it to work. iterm2's native imgcat doesn't play as well with tmux as that one.