Changed the script so the user can generate a map with date range.

luka1199 / geo-heatmap

:world_map: Generate an interactive geo heatmap from your Google location data

MIT License

2.05k stars 226 forks source link

Changed the script so the user can generate a map with date range. #11

Closed ghost closed 4 years ago

ghost commented 4 years ago

I am currently learning github and python if someone has any tips how to make the code cleaner would be nice. :)

arjvik commented 4 years ago

Just an FYI, this is not ready to merge in any way. Nonetheless, good idea!

Some quick tips:

Fix the README by removing all extraneous comments you made. These shouldn't appear in the final README of this script, so you shouldn't make those changes in your PR
Make the example more descriptive
Remove all your extraneous comments in the code
Better more descriptive variable names
Make the date range optional, perhaps with a flag

ghost commented 4 years ago

Mixed up the word and sketch and draft for some reason. The code works even if its messy. The location html file is easy to merge with someone else so i tough that i can merge my friends trip to Denmark we did together for memory instead of pictures. I will try to fix all that code on the weekend. Any tips on how to discuss code before a pull request ,

luka1199 commented 4 years ago

To discuss the code here is fine. It would probably be best to add argparse (#15) for your feature so that it is easier to add features in the future (e.g. #12).

luka1199 commented 4 years ago

I'm going to close this since I already implemented it.

ghost commented 4 years ago

Sorry had lot last week i have just started to improve the code right now.