search

luka1199 / geo-heatmap

:world_map: Generate an interactive geo heatmap from your Google location data
MIT License
2.05k stars 226 forks source link

Add Docker support #38

Closed melkamar closed 4 years ago

melkamar commented 4 years ago

This MR adds support for running the script in Docker, so that there is no hassle with installing dependencies etc.

I am using an image built from my fork of the repository, but feel free to set up Docker Hub integration and update the README to point to an image built from the original repository.

https://hub.docker.com/r/melkamar/geo-heatmap

luka1199 commented 4 years ago

I don't know much about docker but I will maybe look into it in the future. If it could be a security issue to not use the original repo, I can't merge this.

melkamar commented 4 years ago

Fair enough, I'll remove the Docker Hub image reference and just add steps to build this locally. That would not pose any security issue, as all that does is use the files in this repository locally, not uploading nor downloading anything anywhere. Would that be acceptable?

This is mainly a simplification for people already using Docker. They would not have to install any local Python dependencies and clutter their system. For people going this way, there would also (probably) not be any Python-related issue reports that were caused by incorrect packages or other environment misconfiguration.

SuperSandro2000 commented 4 years ago

Building the image themselves works for me. No real issue there.

luka1199 commented 4 years ago

Hey the pull request got closed because I removed some files from the history. Can you rebase on the new fresh history and submit another pull request? Sorry for the inconvenience 😅