lukaaash / sftp-ws

SFTP over WebSockets - client and server package for Node.js
MIT License
34 stars 16 forks source link

ANNOUNCE: websocketfs (a modern fork of this) #10

Open williamstein opened 1 year ago

williamstein commented 1 year ago

Hi,

I'm working on a modern fork of this, which I need for a product my company is building. See

It's open source with the same license as this.

Many thanks for creating sftp-ws, which must have been an enormous amount of work. And thanks for using Typescript way back in 2015!

williamstein commented 1 year ago

NOTE: I'm finding quite a few bugs in this library as I work through getting everything to work systematically for my fuse filesystem. As an example, here

https://github.com/lukaaash/sftp-ws/blob/ec48b5974f13233285483201c1808d7c3b3045c3/lib/sftp-misc.ts#L251

the input writer is completely ignored. I think the code was in a half done debugging state. If anybody else finds this sftp-ws repo, please be aware. I did just fix things to fully support metadata and added support for blocks in this commit: https://github.com/sagemathinc/websocketfs/commit/7fa93a42a4fa59da8eb24b2a1966f204fde13dc5

It's really cool that I could completely understand this code enough to fix issues like this pretty quickly. :-)