[Android Bootcamp] Project 1: Instagram Client - Review my app [V2]

[lukaka7]

My app is complete, please review. /cc @codepathreview @codepath

[codepathreview]

Great work finishing the stories. Here is some feedback after reviewing your code --

• Initializing Fresco should be done in Application's onCreate method
• A good practice will be to refactor Activity's onCreate method into helper methods such as initUi(). This keeps lifecycle methods clean and increases readability, specially as your Activity increases in complexity
• It's preferred that a convenience method be created on the adapter to reload content. This helps DRY up code and encapsulate adapter behavior if the Activity needs to call this several times in different places.
• Attach any listeners in the ViewHolder to cut down on memory usage
  • Rather than setting OnClickListener instances in RecyclerView.Adapter.onBindViewHolder(), which causes more objects to be created and possibly causing the garbage collector to run with higher frequncy, do the following:

public class InstagramPostsAdapter extends RecyclerView.Adapter<InstagramPostsAdapter.ViewHolder> {
    @Override
    public void onBindViewHolder(ViewHolder holder, int i) {
        InstagramPost post = posts.get(i);
        holder.post = post;
    }

    public static class ViewHolder extends RecyclerView.ViewHolder {
        private InstagramPost post;
        private Button btnDoSomethingWithPost;

        public ViewHolder(View itemView) {
            super(itemView);
            btnDoSomethingWithPost = (Button) itemView.findViewById(R.id.btnDoSomethingWithPost);
            setupListeners();
        }

        void setupListeners() {
            btnDoSomethingWithPost.setOnClickListener(new View.OnClickListener(){
                @Override
                public void onClick(View v) {
                    // context can be referenced via v.getContext()
                    doSomethingWithPost(post);
                }
            });
        }
    }
}

• Good job setting up InstagramClient such that every endpoint is represented with a method which then accepts specific parameters and a “handler”
• It is advisable to handle the network error case by overriding onFailure and also notify the user via a Toast that the network request failed.