search

lukakerr / Pine

A modern, native macOS markdown editor
https://lukakerr.github.io/Pine
Other
3.34k stars 168 forks source link

Highlighting on imports #53

Open RWOverdijk opened 5 years ago

RWOverdijk commented 5 years ago

So far, pine looks really nice. There's one tiny thing that caught my eye though, which is the syntax highlighting on typescript code snippets. Specifically imports.

Screenshot 2019-03-27 09 38 28

The original code snippet is:

import { field } from 'wetland';
import { translatable } from 'wetland-i18n';

export class Place {
  @translatable
  @field({ type: 'string' })
  public name: string;
}

As you can see, the destructed imports aren't visible. They're there though, when selected they're visible.

Screenshot 2019-03-27 09 41 00
lukakerr commented 5 years ago

This looks like a problem in the specific theme you're using as I can't reproduce it with a few different themes i've tried as shown below using the atom-one-dark theme. What is the name of the theme you've got applied?

Screen Shot 2019-03-27 at 8 13 43 pm
RWOverdijk commented 5 years ago

@lukakerr Thanks for the fast reply. I'm using whatever comes bundled, I just downloaded and opened it without making any changes. The default is gist. Github does work.

lukakerr commented 5 years ago

Ah I see, I think the issue is related to the very first time the app is opened, and occurs before the theme is changed for the first time (especially since the github-gist theme is meant to be white in appearance). If you change the theme to a different one, and change it back again it should fix the issue. I'll take a look at this and put in a fix soon though.

RWOverdijk commented 5 years ago

After playing with the options a bit, it happens with the system appearance when you have dark mode (MacOS dark mode that is) enabled. Which, I do.