search

lukalabs / cakechat

CakeChat: Emotional Generative Dialog System
Apache License 2.0
1.7k stars 935 forks source link

add another CMD layer to exec the container for non-manual deploys #9

Closed sr229 closed 6 years ago

sr229 commented 6 years ago

Fixes #8 for intention to make it work on Orchestration platforms like Kubernetes or OpenShift.

nikitos9000 commented 6 years ago

Hi @sr229, thanks for your contribution!

Our dockerfiles are primarily made for development usage — i.e. you can start the container, attach to a shell inside of it, run some scripts (training, metrics, etc). Your change makes it very specific, suitable only for production deployment, so I think we can't accept it right now.

If you want to run it in your favorite environment, you'd better set the docker run command (like in https://github.com/lukalabs/cakechat/blob/master/README.md#quick-start) or write your own Dockerfile which includes our docker image by making use of FROM statement and build it.