search

lukas-frey / filament-icon-picker

An icon picker field for Filament
MIT License
106 stars 20 forks source link

Error on relation #14

Closed wrtisans closed 1 year ago

wrtisans commented 1 year ago

Hello, i'm having this error

Declaration of Guava\FilamentIconPicker\Forms\IconPicker::relationship(Closure|string|null $name, Closure|string|null $titleAttribute, ?Closure $modifyQueryUsing = null): static must be compatible with Filament\Forms\Components\Select::relationship(Closure|string|null $name, Closure|string|null $titleAttribute = null, ?Closure $modifyQueryUsing = null): static

here is how im using it.

IconPicker::make('icon') ->label(__('wallets.fields.icon')) ->columnSpan([ 'sm' => 2, ]) ->columns([ 'default' => 1, 'lg' => 3, '2xl' => 5, ]),

im using tenant from filament v3 and this error is in the edit form

wrtisans commented 1 year ago

i've seen it's merged this PR which solves this problem but it's released?

https://github.com/LukasFreyCZ/filament-icon-picker/pull/13

martin-ro commented 1 year ago

Yeah, same here. Waiting for a new release

lukas-frey commented 1 year ago

Hi, yeah sorry. Since I use semantic release to automatically make a release on push and it didn't pick up on the merge request, which I thought it did. It's released now. :)