search

lukas-frey / filament-icon-picker

An icon picker field for Filament
MIT License
101 stars 20 forks source link

Declaration of Guava\FilamentIconPicker\Forms\IconPicker::relationship(Closure|string|null $name, Closure|string|null $titleAttribute = null, ?Closure $modifyQueryUsing = null): static must be compatible with Filament\Forms\Components\Select::relationship(Closure|string|null $name = null, Closure|string|null $titleAttribute = null, ?Closure $modifyQueryUsing = null): static #19

Closed EsiNakesy closed 6 months ago

EsiNakesy commented 6 months ago

Declaration of Guava\FilamentIconPicker\Forms\IconPicker::relationship(Closure|string|null $name, Closure|string|null $titleAttribute = null, ?Closure $modifyQueryUsing = null): static must be compatible with Filament\Forms\Components\Select::relationship(Closure|string|null $name = null, Closure|string|null $titleAttribute = null, ?Closure $modifyQueryUsing = null): static

change public function relationship(string|Closure|null $name, string|Closure|null $titleAttribute = null, ?Closure $modifyQueryUsing = null): static to public function relationship(string|Closure|null $name = null, string|Closure|null $titleAttribute = null, ?Closure $modifyQueryUsing = null): static solve the issue

AlexisSerneels commented 6 months ago

This bug was introduced with the release of v3.1.22 for the information.

AlexisSerneels commented 6 months ago

Fix suggested in PR: https://github.com/lukas-frey/filament-icon-picker/pull/18

malle-pietje commented 6 months ago

May I rudely bump this? 😉

We are using the IconPicker in one of our Actions for the UserResource which is now broken...

mohssineAboutaj commented 6 months ago

Use the solution in #18 and edit the library code manually until the developer accepts the PR, i hope he will

malle-pietje commented 6 months ago

Use the solution in #18 and edit the library code manually until the developer accepts the PR, i hope he will

Exactly what I have done but it's not such a clean fix 😉

lukas-frey commented 6 months ago

It's fixed in release 2.0.3.

Sorry for the delay, I had some personal issues and I couldn't find time to check my github.

malle-pietje commented 6 months ago

Thanks!