search

lukas-krecan / JsonUnit

Compare JSON in your Unit Tests
Apache License 2.0
890 stars 114 forks source link

Make custom matcher regexp DOTALL #617

Closed EDbarvinsky closed 1 year ago

EDbarvinsky commented 1 year ago

We have face an issue, that custom matcher fails comparison in case if input parameter contains line terminators. To make (.*) match everything I suggest to update current regexp to be DOTALL if you need more appropriate example, please take a look here

EDbarvinsky commented 1 year ago

@lukas-krecan review plz :-)

lukas-krecan commented 1 year ago

Looks good, thanks.

I was thinking about an easy way how to apply DOTALL only on the second dot, but it would not be that easy. Actually, the first dot should not have been a dot, but can't change it without breaking backwards compatibility.

lukas-krecan commented 1 year ago

Released as 2.37.0

EDbarvinsky commented 1 year ago

wow! How fast. Tnx :-)