search

lukas-krecan / future-converter

Converts between various future types
Apache License 2.0
155 stars 39 forks source link

RxJava Observables to Java 8 Completable future #10

Open gbsmith opened 7 years ago

gbsmith commented 7 years ago

Lukas,

A couple of years ago you wrote a blog post on RxJava Observable <-> Java8 CompletableFuture. I don't see that code integrated into the future-converter lib. Am I looking in the wrong place? Or is there a better solution there now? If not, why not add that code to the lib?

-GBS

gbsmith commented 7 years ago

BTW, I am asking because we are trying to integrate Netflix Hystrix which is Rx Observable based with some of our async code which is all Java8 CompletionStage. It looks like we might have to convert back and forth.

lukas-krecan-lt commented 7 years ago

Hi, it's here https://github.com/lukas-krecan/future-converter/blob/master/rxjava-java8/src/main/java/net/javacrumbs/futureconverter/java8rx/FutureConverter.java It's not converting Observable but Single since it's more like Future.