lukas-reineke / indent-blankline.nvim

Indent guides for Neovim
MIT License
3.98k stars 99 forks source link

fix: highlights.lua setup builtin hl groups for all Ibl names #885

Closed gavinbeatty closed 2 months ago

gavinbeatty commented 2 months ago

IblScopeChar and IblChar were missing.

Without this change, it's possible to trigger the "No highlight group found" path for those names. For example, I use the plugin junegunn/goyo.vim which when activated, pushes some theme/highlight changes to create a distraction-free writing environment. When exiting goyo mode, the missing name errors occur. I didn't inspect the code much, just noticed some of the builtin groups were not set in the relevant setup function, and adding them seemed to resolve my issue.

I don't know what the best initial values to setup would be, but I chose to copy from Normal. My casual inference was the *Char was generic sounding enough to warrant copying "normal text". My only visual inspection of the results is that it looks fine to my non-aesthete eyes.

It's possible that goyo is still doing something wrong here, but facially this seems like the correct thing to do.

lukas-reineke commented 2 months ago

IblScopeChar and IblChar are not missing, they are not correct highlight groups in the first place. They do not exist in this repo at all.
Maybe goyo or the color scheme you are using has added them by mistake?

gavinbeatty commented 2 months ago

Ah, I found those names by doing a recursive grep in my lazy directory, but didn't notice that IblChar and IblScopeChar come from NvChad plugins, not ibl itself.

Fix belongs in base46. Sorry for the noise.