lukas-tr / vscode-materialdesignicons-intellisense

Provides intellisense, search and hover preview for Material Design Icons
https://marketplace.visualstudio.com/items?itemName=lukas-tr.materialdesignicons-intellisense
MIT License
35 stars 7 forks source link

Some Icons changed name in mdi v5.1.45 and new ones are present #13

Closed Ares9323 closed 4 years ago

Ares9323 commented 4 years ago

Hi, today I started a new laravel project and I noticed the "mdi-settings" icon is now called "mdi-cog", i think others may have changed and there are 100 new icons as you can see here.

Are you going to update the extension or releasing another version for backward compatibility? Do you have an automated system to include new icons or do you need help doing it? If you need some help you can explain me what to do and I'll send you a pull request 😉

Thank you, have a nice day!

lukas-tr commented 4 years ago

An automated system would be perfect. I have two ideas of how to implement it:

I think option 2 is more flexible as this would allow users to choose the version they want to work with.

Thanks for the offer, but I can do it myself and there are many other great projects that need help more than I do.

Ares9323 commented 4 years ago

Yeah both ideas are good, I was thinking to look inside the node_modules workspace folder to make the extension work in projects with different versions of mdi. Unfortunately there is no svg folder in my node_modules/@mdi, there's only the font folder so I don't think this solution is possible if svg files are needed.

Another thing I was asking myself is if the alias system is something you made or it's provided by mdi directly, because it would be very bad to lose it with automation. image Icons are pretty difficult to find in the official cheatsheet, I really love aliases <3

Thanks for the fast answer 😊

lukas-tr commented 4 years ago

I didn't create the aliases. They are found inside node_modules/@mdi/svg/meta.json. The cheat sheet doesn't have them but the main page (https://materialdesignicons.com/) uses them when searching. image

I also can't count on users having npm installed. I will have to use the npm api directly to get all versions and download and extract the @mdi/svg package somewhere.

Looking inside node_modules would still be a good idea as I could automatically detect the right version to use.

Ares9323 commented 4 years ago

Thank you for the tip, I didn't know about the "smart search"!

lukas-tr commented 4 years ago

You can now switch between versions manually or set it to always use the latest release.

Switching between versions

Ares9323 commented 4 years ago

Wonderful result, thanks!