search

lukas-weber / Carlo.jl

Monte Carlo framework that provides MPI parallelization, checkpointing and statistical postprocessing in an algorithm-agnostic way.
MIT License
28 stars 2 forks source link

Make Complex observables evaluable #13

Closed hz-xiaxz closed 1 month ago

hz-xiaxz commented 1 month ago

related to (#12 ) After some searching, I found this package BinningAnalysis.jl implements likewise jackknife resampling method from QMC results, and he follows the julia convention to calculate var(x) = var(real(x))+var(imag(x)). I think this is reasonable enough then.

In this PR I made the type of error be alway :<Real and fixed some issue in reading the complex observable from the json result file.

hz-xiaxz commented 1 month ago

Thanks for the review. As I'm new to Github, how can I sign for my commit?

lukas-weber commented 1 month ago

https://docs.github.com/authentication/managing-commit-signature-verification/about-commit-signature-verification

But, since signing existing commits can be a bit tricky, we can skip signatures for this one. :)

I also noticed CI is failing for nightly, but it seems unrelated to your changes.