lukas / ml-class

Machine learning lessons and teaching projects designed for engineers
https://www.youtube.com/channel/UCBp3w4DCEC64FZr4k9ROxig
GNU General Public License v2.0
2.34k stars 1.17k forks source link

fixes the cnn-text example, closes #39 #64

Closed charlesfrye closed 4 years ago

charlesfrye commented 4 years ago

This was a fun one! The videos/cnn-text example got a bit mangled: one of the examples was using a different version of the dataset (downloaded from Keras) than the other (using a hand-rolled downloader), and the hand-rolled downloader was missing!

I rewrote it (download-imdb.py) and the data loading code (imdb.py) to remove some bugs and do my best to make them OS-independent.

Also, the differences in setup meant that the code had been changed since the video. I reverted it and confirmed that we could get good performance.