Unable to collapseall when using ControlledTreeEnvironment

[khamphou]

Describe the bug ExpandAll does not work, no sub nodes are expanded CollapseAll collapse only one parent folder at a time

To Reproduce

• visit page https://codesandbox.io/s/react-complex-treeview-controlledtreeenvironment-pw3cly
• click on expandall button => nothing happens
• expand manually many nodes
• click on collapseall, only one node is collapsed at a time

Expected behavior all sub nodes should open, none of them are expanded using the controlledtreeenvironment. it works fine using uncontrolledtreeenvironment.

Screenshots

Desktop (please complete the following information):

• OS: Windows 10
• Browser Edge
• Version 2023

Additional context react-complex-tree 2.1.1

[lukasbach]

Hi, I just had a look, and there seems to be some issues with closures in your code. Replace the onExpandItem and onCollapseItem props with

      onExpandItem={(item) => {
        console.log("expand", item);
        setExpandedItems((items) => [...items, item?.index]);
      }}
      onCollapseItem={(item) =>
        setExpandedItems((items) =>
          items.filter((expandedItemIndex) => expandedItemIndex !== item?.index)
        )
      }

Then it works: https://codesandbox.io/s/react-complex-tree-expandall-closure-fix-ekssib

[khamphou]

thank you for your help. sorry for the response delay. i was sick last weeks.