search

lukasbestle / kirby-versions

Keep track of content changes and switch between different versions from the Kirby 3 Panel
MIT License
77 stars 4 forks source link

Docs enhancement (Wiki) #14

Closed hariom147 closed 1 year ago

hariom147 commented 1 year ago

Hi Lukas, thank you for making this great plugin.

While following the docs, I noticed that for someone who is a beginner with git, this instruction might be confusing:

Important: Please now verify using the search function of your terminal (Ctrl/Cmd F) that no .lock file was added,

I suggest the following edit:

Important: Please now verify that no .lock file was added by listing the added files. Enter git status in your terminal and then use the search function of your terminal (Ctrl/Cmd F) to be sure no .lockfiles were added, since that would break the plugin's behavior later.

(I would have made a PR, but Wikis don't get forked...)

lukasbestle commented 1 year ago

Thanks for your feedback. 👍

Running git status should not be necessary though because git add also lists the files it adds. Or didn't it do that for you?

hariom147 commented 1 year ago

Or didn't it do that for you?

No, it didn't and doesn't in general when I use git in terminal. But now that you mention it, it totally makes sense...

Although I never (consciously) changed any git settings in that regard...