search

lukasbischof / finite-field-calculator

BSD 2-Clause "Simplified" License
0 stars 0 forks source link

Calculator assumes Z_m instead of an actual finite field #1

Open skius opened 4 years ago

skius commented 4 years ago

When inputting 4 as field bound, the calculator assumes Z_4, which is not a finite field, instead of GF(4), which is.

I would recommend making it explicit that this calculator works with the ring Z_m or adjusting it to properly make use of Galois fields where applicable.

Still, props for showing which elements in the ring Z_m are units.

lukasbischof commented 4 years ago

That's why there is the

caution

section in README.md 😉

skius commented 4 years ago

Thanks for getting back to me! I appreciate the warning, but I would argue one of the key aspects of open source development is being open to feedback.

lukasbischof commented 4 years ago

@skius Feedback accepted, pull request anticipated 😜