upgrade to use collections.abc as needed since python 3.6+

lukasgeiter / mkdocs-awesome-pages-plugin

An MkDocs plugin that simplifies configuring page titles and their order

MIT License

472 stars 36 forks source link

upgrade to use collections.abc as needed since python 3.6+ #47

Closed aromeyer closed 2 years ago

tgrelka commented 2 years ago

I was about to make the same PR.

Some context: Python 3.10 removed the deprecated collection aliases, leading to failing mkdocs builds, thus this change now is required for mkdocs-awesome-pages-plugin working on current python versions.

lukasgeiter commented 2 years ago

Hey @aromeyer, thanks a lot for this PR!

Since this plugin has a minimum requirement of 3.5 and collections.abc has been introduced in 3.3, I believe we don't need a fallback. Could you change it to the following? (and update the usage accordingly)

from collections.abc import Iterable

lukasgeiter commented 2 years ago

This PR has been superseded by #49. The issue is fixed in v2.5.1.