lukashornych / evitalab

Official web-based GUI client for evitaDB e-commerce database. It is built to help developers who use evitaDB with exploring and debugging their domain structure and data. Besides standard query executing, it also supports multiple no-code tools to quickly navigate through domain structure, docs and data without needing to write any queries.
https://github.com/lukashornych/evitalab
Apache License 2.0
7 stars 2 forks source link

UI/UX styling improvements #48

Closed lukashornych closed 11 months ago

lukashornych commented 12 months ago

Our GD prepared some graphics changes (colors, icons, styling) that would match our evitaDB docs. portal and would look nicer. We need to incorporate those changes into our codebase.

Ideally, we want most of the changes to done globally by defining custom theme in src/plugins/vuetify.ts (docs) and overriding default props for Vuetify components. Other options are to override global CSS in src/styles/settings.scss or change styling directly in the custom components, but this should be used sparingly.

Currently used icons: https://pictogrammers.com/library/mdi/

To-Do

MiroslavAlt commented 11 months ago

@lho - I have prepared styles/features acordingly. Have a look.

lukashornych commented 11 months ago

@MiroslavAlt It's awesome :heart_eyes: it's very pleasant to use. Good job :+1: Just a few small things I found, nothing major + some things we talked about already:

Most likely bugs

Nice to have

lukashornych commented 11 months ago

@MiroslavAlt FYI: When trying to solve issues with the green almost non-visible codemirror code selection and autocomplete popup, I've discovered that we tried to use two different codemirror themes simultanously :smile: They were somehow rewriting each other and the used token coloring wasn't even from the used dracula theme. After fixing this, I've discovered that the thememirror's dracula theme is not quite working, there for still problem with the token selection. So I've found different version https://github.com/dennis84/codemirror-themes which seems to work quite good, the selection is cleary visible and the autocomplete too.

Also, I've notice that on the evitaDB web although the theme for prism is called in dracula in our code, really it's the default vsDark which is not similar to dracula nor the Visual Studio One Dark. I wanted to use this theme in lab as well, but it seems that it's Prism-specific. We should discuss it more.

lukashornych commented 11 months ago

@MiroslavAlt I've made couple fixed/changes, please look at the changes so you know what's been done. Also, I've corrected the variants on VChips as we've talked about, i.e. plain for non-clickable and outline for actionable.

lukashornych commented 11 months ago

@MiroslavAlt I've implemented the RSS feed fetcher. Only problem is CORS headers on the RSS feed endpoint, so I've prepared MR for the evitaDB web, please look at it when you have time.

lukashornych commented 11 months ago

@MiroslavAlt FYI I've merged the reworked grid cell detail window from #8 to this branch, so that we could review its UI/UX. Some fixes needed to be done, but now it seems quite ok to me,

lukashornych commented 11 months ago

@MiroslavAlt I've changed toast notification coloring according to alert/notes on evitaDB web. Is it okay with you? I had to improvise little bit, because on the evitaDB web the background color is transparent so it blends with the background which I didn't want because there may be values underneath, but overall we use same background as on the evitaDB web so it should match.

success info error

EDIT: since than, I've managed to fix the icons to outline versions to match.

MiroslavAlt commented 11 months ago

@MiroslavAlt I've implemented the RSS feed fetcher. Only problem is CORS headers on the RSS feed endpoint, so I've prepared MR for the evitaDB web, please look at it when you have time.

Merged!

MiroslavAlt commented 11 months ago

@MiroslavAlt I've changed toast notification coloring according to alert/notes on evitaDB web. Is it okay with you? I had to improvise little bit, because on the evitaDB web the background color is transparent so it blends with the background which I didn't want because there may be values underneath, but overall we use same background as on the evitaDB web so it should match.

success info error

EDIT: since than, I've managed to fix the icons to outline versions to match.

Brilliant, thank you!

lukashornych commented 11 months ago
lukashornych commented 11 months ago
lukashornych commented 11 months ago

FYI: After some thinking, I want to release this as 1.0.0 so there cannot be any alpha working on welcome screen, and (breaking) commit must exist. Also, I need to aggregate all important changes and new feature for the release summary.

Maybe we could wait for https://github.com/lukashornych/evitalab/issues/52 and representative attributes?

MiroslavAlt commented 11 months ago

FYI: After some thinking, I want to release this as 1.0.0 so there cannot be any alpha working on welcome screen, and (breaking) commit must exist. Also, I need to aggregate all important changes and new feature for the release summary.

Maybe we could wait for #52 and representative attributes?

@lukashornych I've made changes as discussed here and on out meetings.