search

lukasjapan / bt-speaker

A simple Bluetooth Speaker Daemon for the Raspberry Pi 3
GNU General Public License v3.0
493 stars 94 forks source link

Add PIN and make pin code configurable #71

Closed brknkfr closed 4 years ago

lukasjapan commented 4 years ago

I am not quite sure how this is working.

About pass_key settings: Without the capability settings none of the callbacks are going to be called.. Actually, unless using the keyboard or yesno confirm capabilities, things won't be secure anyway. That would be outside the scope of a daemon that is supposed to just run (headless).

About pin_code settings I couldn't find a way to get the RequestPasskey/DisplayPasskey working, at least not on a vanilla raspberry installation. It looks in the code like it works the same as passkey.. What should be the expected behavior? Does this depend on the connecting device? I used an Iphone.

EDIT: Never mind, I just saw this in the next PR.

btmgmt ssp off

Now it makes sense, but the pass_key setting seems meaningless.

lukasjapan commented 4 years ago

It seems like a priviledged command, bt-speaker should probably not handle this but it can be written in the readme.

I will also move this into the bluez section since it fits better in there.