search

lukasjarosch / skipper

Inventory based templated configuration library inspired by the kapitan project
https://lukasjarosch.github.io/skipper/
MIT License
11 stars 3 forks source link

Do not use the 'target' key in Data #26

Closed lukasjarosch closed 2 years ago

lukasjarosch commented 2 years ago

Currently, if you define custom keys in a target, these are added under the target key.

Let's say one has defined: foo.bar in the target and no class foo. Then the Data path would be target.foo.bar. But once the foo class exists and is used in the target, the data path changes to foo.bar.

This is not a bug, it was done on purpose. But the inconsistency is worse than any potential benefit from using the target key. Even more so, there is no benefit, hence the target key should not exist at all.

lukasjarosch commented 2 years ago

This will most likely break some examples.