search

lukasjarosch / skipper

Inventory based templated configuration library inspired by the kapitan project
https://lukasjarosch.github.io/skipper/
MIT License
11 stars 3 forks source link

Template renaming should not be exclusive to components #32

Closed lukasjarosch closed 1 year ago

lukasjarosch commented 1 year ago

Currently, the templater only allows renames for component rendering. But it would be nice to be able to expose that functionality to the other template rendering methods Execute and ExecuteAll.

This would introduce just a small change and generalise the use of Skipper even more.

alxndr13 commented 1 year ago

i'll work on this one, maybe i'll come up with something in the next hour or so

alxndr13 commented 1 year ago

i'm not able to get the make example tests running, maybe i need some more infos the next few days :)

lukasjarosch commented 1 year ago

The secret example is currently the one whith which I am working and should be running. I'm not sure about the other examples.

alxndr13 commented 1 year ago

Seems like the others do not work anymore.. i'll see what i can do :)

alxndr13 commented 1 year ago

pushed a first draft into https://github.com/lukasjarosch/skipper/pull/34

lukasjarosch commented 1 year ago

You rock 🚀, thanks for contributing in the first place. I've added a few comments to the PR, I like it 😄.

I've also added a feature request https://github.com/lukasjarosch/skipper/issues/36 to work on the examples and make them more meaningful in the future.