search

lukasjarosch / skipper

Inventory based templated configuration library inspired by the kapitan project
https://lukasjarosch.github.io/skipper/
MIT License
11 stars 3 forks source link

fix: use azure key vault name and key name if key ID is not set #51

Closed andaryjo closed 1 year ago

andaryjo commented 1 year ago

While azure key vault name and key name instead of key ID is theoretically supported, they never got used by the driver.

lukasjarosch commented 1 year ago

That's well spotted! The reason the vault and key name can be set has to do with the way I initially configured the driver until I changed my mind and decided to parse the full KeyID instead which made these values obsolete.

I'm not sure whether we should even allow configuring the key that way. Configuring using the KeyID is way easier anyway. For the sake of simplicity we could also just remove these config values altogether and only allow using the KeyID. What are your thoughts on this?

andaryjo commented 1 year ago

I'd prefer only keeping the key ID and removing the other attributes.