search

lukasjarosch / skipper

Inventory based templated configuration library inspired by the kapitan project
https://lukasjarosch.github.io/skipper/
MIT License
11 stars 3 forks source link

78 cannot replace variables with values of type map from another class sometimes #79

Closed lukasjarosch closed 6 months ago

andaryjo commented 6 months ago

this is actually what I tried as well, thinking "if it is type map[string]interface{}, simply support map[string]interface{}" :D

in our testing this worked sometimes but would for some unknown reason result in infinite loops other times. But likely I messed something up. I will try out this fix first thing tomorrow.

andaryjo commented 6 months ago

I can also see you removed the duplicate replaceVariables function. It took @alxndr13 and me some time to figure out what that was about. :D

lukasjarosch commented 6 months ago

@andaryjo Hm, I've not come across an endless loop. I must admit that I've probably not tested as extensively as you did, so I'm looking forward to your results.

lukasjarosch commented 6 months ago

Yeah, the duplicate did somehow end up in main. Really sorry about that :pensive:

andaryjo commented 6 months ago

Tested, and with this fix now everything seems to work flawlessly 🚀

alxndr13 commented 6 months ago

Tested, and with this fix now everything seems to work flawlessly 🚀

I can still trigger the error, lets talk about this once you're awake again 😂

Edit: Nevermind, can't trigger it again. what the hell