search

lukasjhan / sd-jwt-io

SD JWT debugging page
https://sdjwt.co
MIT License
4 stars 1 forks source link

Rename Section Titles for Encoder/Decoder Modes #31

Closed hismethod closed 6 months ago

hismethod commented 6 months ago

Proposing to rename section titles for clarity:

lukasjhan commented 6 months ago

@hismethod I think the term Result and Raw is ambiguous.

The term Result represents the decoding results from encoded credentials. I don't understand the term Raw represents.

I think it's better to follow the UX in jwt.io. It's a more familiar way

lukasjhan commented 6 months ago

If you think the current terms are not clear enough, I propose to change our modes into issue, present and verify

lukasjhan commented 6 months ago

@yunseorim1116 Can you share your thoughts?

yunseorim1116 commented 6 months ago

I feel like it's really hard to redefine terms to make it easier for everyone to use. I think it's best to follow the terminology on JWT's site as closely as possible. The term Raw is a bit unfamiliar to me. How about something like [Encoded (or Token) | Decode Result ]?

lukasjhan commented 6 months ago

I feel like it's really hard to redefine terms to make it easier for everyone to use. I think it's best to follow the terminology on JWT's site as closely as possible. The term Raw is a bit unfamiliar to me. How about something like [Encoded (or Token) | Decode Result ]?

That sounds good to me.

lukasjhan commented 6 months ago

1st, For right section: [Encoded | Decoded] Result