search

lukaskleinschmidt / kirby-snippet-controller

Define snippet controllers in a similar way to page controllers
MIT License
21 stars 0 forks source link

Version Info missing in System Panel #2

Open animaux opened 1 year ago

animaux commented 1 year ago

Maybe more of a cosmetic issuse, since the second last update there is no more plugin version/update info in the panel:

Bildschirmfoto 2023-09-25 um 09 59 24
lukaskleinschmidt commented 1 year ago

Thats odd. Which version do you have installed?

animaux commented 1 year ago

Current 2.1.0

lukaskleinschmidt commented 1 year ago

Can't really replicate the issue right now. Tested it locally and live with Kirby 3 and 4. Do you have any additional infos?

Can you please try to install this package https://github.com/lukaskleinschmidt/kirby-laravel-vite. It uses the same "structure" composer wise. Just to see if versions are showing up there.

animaux commented 1 year ago

I have installed this simply by downloading the release and copying it into an almost untouched kirby v3 plainkit installation (not using composer). Doing that with the laravel extension yields the same result:

Bildschirmfoto 2023-09-25 um 10 26 46

I have no idea how kirby plugings are structured, but looking at the composer.json files in your and the other extensions, there is no "version":-line in yours. Is that where the panel gets its information from?

lukaskleinschmidt commented 1 year ago

That seems to be the culprit here. It works fine if you install the package via composer. But not if you download it or install it with git.

I actually removed the version (from most of my plugins) because of the reasons mentioned here:

Specifying the version yourself will most likely end up creating problems at some point due to human error. https://getcomposer.org/doc/04-schema.md#version

Not sure the right course of action here. I like to keep things simple with my plugins. No custom actions for publishing releases that might be able to automatically update the composer.json. But I also get that not having the version in the panel might be an annoyance for some.

animaux commented 1 year ago

OK, I see, thanks for looking into this!

lukaskleinschmidt commented 1 year ago

I will keep this one open to see if I can find a fix for this at some point.

animaux commented 1 year ago

Tested it locally and live with Kirby 3 and 4.

BTW. So this plugin will work in Kirby 4 straight away? :)

lukaskleinschmidt commented 1 year ago

Yes, should work right out of the box