search

lukaskleinschmidt / kirby-types

IDE Helper for Kirby
MIT License
18 stars 0 forks source link

Base root is not defined / types.php is not writable #1

Closed bezin closed 1 year ago

bezin commented 1 year ago

Hi Lukas,

thanks for this plugin. I wanted to try it out, but when I run kirby types:create it fails due to /types.php not being writable. This path made me suspicious and as far as I gathered from the code, the path should have been prepended with the Kirby base root. I have this root set up in my index.php but apparently these are ignored by Kirby CLI and base does not seem to be a default root? When I run kirby roots it also does not list a base root.

Any idea what might be the issue? I don't have much experience with the Kirby 3 CLI, but I am happy to provide more information. Just let me know.

Best

Edit: The Kirby version used is 3.9.2

lukaskleinschmidt commented 1 year ago

I was not aware that the base is actually just used/mentioned for the public folder setup. I think having it along the lines of $this->app->root('base') ?? $this->app->root('index') should fix that. I will push a fix for that

lukaskleinschmidt commented 1 year ago

Please let me know if that works

bezin commented 1 year ago

Works flawless now, thanks for the quick fix 🙏 👍