search

lukasoppermann / design-token-transformer

Base repo to transform json design tokens from the figma design token plugin via amazon style dictionary.
MIT License
151 stars 227 forks source link

Some units are called "pixel" while others are called "pixels" #6

Closed mwargan closed 3 years ago

mwargan commented 3 years ago

Suggested to either keep consistent naming, or modify transformTokens.js line 9 to read return (token.unit === 'pixel' || token.unit === 'pixels') && token.value !== 0

lukasoppermann commented 3 years ago

Hey @mwargan thanks for raising this. Can you let me know which units are called 'pixels'? I have a hard time finding it in the code base. Thanks.

mwargan commented 3 years ago

@lukasoppermann so far for me only lineHeight has been plural.

lukasoppermann commented 3 years ago

Hey @mwargan this should be fixed in the latest plugin release.