lukasoppermann / design-tokens

🎨 Figma plugin to export design tokens to json in an amazon style dictionary compatible format.

https://www.figma.com/community/plugin/888356646278934516/Design-Tokens

MIT License

964 stars 134 forks source link

Museo Sans Font Weight Support - All font weights are 400 #198

Closed bryanlopez-ibotta closed 2 years ago

bryanlopez-ibotta commented 2 years ago

I created a text style in Figma with Museo Sans at 300 font-weight but when exported it says this and any other text style I define with this font are font-weight "400" which isn't even an option for that font!

bryanlopez-ibotta commented 2 years ago

Okay, I see the issue. Museo only uses numbers to describe the weights. We need to add {300: 300, 400: 400}, etc. to https://github.com/lukasoppermann/design-tokens/blob/59c35552d424f4ef69c703063939fd7ebd17490c/src/extractor/extractFonts.ts#L23

I will make a PR.

bryanlopez-ibotta commented 2 years ago

199 should hopefully fix this.

lukasoppermann commented 2 years ago

Thanks for the fix.