lukasoppermann / design-tokens

🎨 Figma plugin to export design tokens to json in an amazon style dictionary compatible format.
https://www.figma.com/community/plugin/888356646278934516/Design-Tokens
MIT License
971 stars 134 forks source link

add a button solely for saving the settings. #268

Closed hayawata3626 closed 1 year ago

hayawata3626 commented 1 year ago

Related #267

Please let me know if there are any issues with the placement of the button or if anything feels out of place.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 6021607250


Totals Coverage Status
Change from base Build 5956473320: 0.0%
Covered Lines: 495
Relevant Lines: 731

💛 - Coveralls
lukasoppermann commented 1 year ago

Hey, fine by me, one thing though: → The save button should be a secondary button and only the export button should be blue

Or what about this:

Instead of all this we do it like this:

So if you just want to change settings, you change them and click the X if you want to export you click export afterwards. WDYT?

hayawata3626 commented 1 year ago

@lukasoppermann I agree!

So if you just want to change settings, you change them and click the X if you want to export you click export afterwards. WDYT?

I will do this.

hayawata3626 commented 1 year ago

@lukasoppermann I pushed the code.

hayawata3626 commented 1 year ago

@lukasoppermann If there are any use cases that are not supported, we will correct them.

lukasoppermann commented 1 year ago

Looks good, sorry it took so long to review.