Update to jest@26 leads to 4 tests failing.

lukasoppermann / html5sortable

VanillaJS sortable lists and grids using native HTML5 drag and drop API.

http://lukasoppermann.github.io/html5sortable/index.html

MIT License

1.62k stars 462 forks source link

Update to jest@26 leads to 4 tests failing. #548

Open lukasoppermann opened 4 years ago

lukasoppermann commented 4 years ago

When updating the dependencies to jest@26 and ts-jest@26 4 tests in the __tests__/events/events.test.ts test file fail.

@kaffarell if you have time to look into this, it would be great. It is weird, but probably has to due with some change from jest.

kaffarell commented 4 years ago

Sorry, I was not able to fix this. What I have found out:

That the dataTransferObject now has a type (format) as first parameter
That we maybe have to add a type to the created customEvent (CustomEvent & {dataTransfer?: any})

But sadly none of these things have solved the issue 😭

lukasoppermann commented 4 years ago

Hey @kaffarell thank you for looking into it! I guess we just have to keep trying to figure it out. Let's skip jest@26 for now and release without it.

lukasoppermann commented 3 years ago

@atodorov do you think we should start a branch with to upgrade ts-jest & jest to @26? It will need quite some fixes though.

atodorov commented 3 years ago

A branch + a draft PR seem like a good first step, IDK what is breaking ATM and how much work that would be to adjust the tests.

lukasoppermann commented 3 years ago

Somehow it is mainly TS errors. Some tested parts return false instead of true now which is weird. Do you want to create a draft PR for this?