fix: max items settings correction

lukasoppermann / html5sortable

VanillaJS sortable lists and grids using native HTML5 drag and drop API.

http://lukasoppermann.github.io/html5sortable/index.html

MIT License

1.62k stars 462 forks source link

fix: max items settings correction #862

Closed norbitrial closed 2 years ago

norbitrial commented 2 years ago

This PR is intended to fix #844 bug.

When on the connected lists there is only 3 children allowed to dragged. Tested on my local, see the below screenshots:

3rd item is still draggable:
4th item before the fix:
4th item with this fix:

As requested in the contributing guidelines the dist folder is not included. 👍

lukasoppermann commented 2 years ago

Sorry for it taking so long @norbitrial I missed the PR completely. Thank you very much.

coveralls commented 2 years ago

Coverage remained the same at 86.312% when pulling a5c2582f36423844368638c53dbda4553c7b6317 on norbitrial:master into 6894f4727f86832cea08370c6d4167a225c0d115 on lukasoppermann:master.