Revert "Return the complete response, not just first chunk"

lukasredev / skipper-azure

Skipper adapter for Microsoft Azure storage.

MIT License

7 stars 12 forks source link

Revert "Return the complete response, not just first chunk" #5

Closed robertrossmann closed 7 years ago

robertrossmann commented 9 years ago

Reverts lukasreichart/skipper-azure#3

Sorry about this - the issue with data corruption was caused by my own incorrect usage of the library. It is not very good practice to buffer the whole file into memory before returning it to client, anyway...

robertrossmann commented 7 years ago

Closing due to no interest to merge this. You should be aware that the current implementation is very inefficient because it buffers the file's contents into memory (in full) before delivering to the client, completely breaking Skipper's main purpose of streaming all data.

lukasredev commented 7 years ago

@robertrossmann I am open for ideas how to improve this

robertrossmann commented 7 years ago

The solution to the problem was in the pull request, you just need to merge it. 👍