lukasroegner / homebridge-apple-tv-remote

Plugin for controlling Apple TVs in homebridge.
MIT License
132 stars 13 forks source link

Feature Request - Add device name to button name #19

Closed NorthernMan54 closed 4 years ago

NorthernMan54 commented 4 years ago

I have a user of my homebridge-alexa plugin that is using your plugin and are having an issue caused by duplicate device names. This is due to using the same device name on multiple accessories, and Alexa having issues with duplicate names.

To workaround this, is it possible to implement an option like this from the other Apple TV Plugin?

"defaultSwitchesIncludeATVName": false

And if enabled add the device name to the button name ie Play ( Family Room )

Tks

lukasroegner commented 4 years ago

Could be implemented...but the user can just rename the accessory and the services in the Home app, wouldn't that be easier???

NorthernMan54 commented 4 years ago

Unfortunately renaming in the Home app does not work, as the name change is done within the home app and not published back to homebridge.

Sent from my iPad

On Mar 26, 2020, at 3:33 AM, Lukas Rögner notifications@github.com wrote:

 Could be implemented...but the user can just rename the accessory and the services in the Home app, wouldn't that be easier???

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

johnlietzke commented 4 years ago

Work arounds you can think of for the duplicate name that NorthernMan54 mentions?

NorthernMan54 commented 4 years ago

Would you be open for a pull request with this enhancement?

johnlietzke commented 4 years ago

Sure. Thank you. Please send me any information about the pull request.

lukasroegner commented 4 years ago

I added two settings for the initial names of the switches (onOffSwitchName and playPauseSwitchName), so that you have full control over the name that you want to use with Alexa.

johnlietzke commented 4 years ago

Thank you. I looked over your repository for a minutes before dinner and was going to try and fork a solution tomorrow.

Thank you again.

NorthernMan54 commented 4 years ago

Tks @lukasroegner very much appreciated