search

lukasroegner / homebridge-apple-tv-remote

Plugin for controlling Apple TVs in homebridge.
MIT License
132 stars 13 forks source link

Add multi button support. #66

Closed Luitwieler closed 4 years ago

Luitwieler commented 4 years ago

Updated documentation, added the logic for multi button support and included wildcards for bundleIndentifier.

A pull request for the the following topic: https://github.com/lukasroegner/homebridge-apple-tv-remote/issues/62#issuecomment-699543137

Luitwieler commented 4 years ago

@lukasroegner I created a PR however I see that we have some conflicts.

Luitwieler commented 4 years ago

@lukasroegner Conflicts are now resolved and includes the changes for stabilizing the playing state while keeping the logic for current app active.

lukasroegner commented 4 years ago

Thanks, I'll review the changes!

Luitwieler commented 4 years ago

@lukasroegner Thanks! Let me know if you have any questions. Never programmed TypeScript before, but I tested the code on tvOS 14.2 and seems to be working fine.

Luitwieler commented 4 years ago

@lukasroegner I pushed the changes to the branch and should resolve all the comments. Thanks for the feedback!

Luitwieler commented 4 years ago

@lukasroegner Done, ready to be merged to Master!